Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(consensus): Rename router_verifier to block_verifier_router #6998

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 19, 2023

Motivation

router_verifier sounds like something that verifies routes or routers. But what it actually does it route blocks to other verifiers.

Solution

Do a mass rename to block_verifier_router using these commands:

git ls-tree --full-tree -r --name-only HEAD | xargs sed -i -e 's/router_verifier/block_verifier_router/g'
cargo fmt --all

Review

You can automatically review this code using the review instructions at:
https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/mass-renames.md#universal-renames-with-sed

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

…er_verifier/block_verifier_router/g'

cargo fmt --all
@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 19, 2023
@teor2345 teor2345 requested review from a team as code owners June 19, 2023 00:38
@teor2345 teor2345 self-assigned this Jun 19, 2023
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team June 19, 2023 00:38
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #6998 (a56d8b4) into main (0da2dcb) will decrease coverage by 0.07%.
The diff coverage is 86.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6998      +/-   ##
==========================================
- Coverage   77.49%   77.43%   -0.07%     
==========================================
  Files         310      310              
  Lines       41536    41548      +12     
==========================================
- Hits        32189    32173      -16     
- Misses       9347     9375      +28     

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jun 20, 2023
@mergify mergify bot merged commit 56a7638 into main Jun 20, 2023
@mergify mergify bot deleted the rename-block-router branch June 20, 2023 07:11
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants