Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): De-duplicate and fix version handling code #6996

Merged
merged 5 commits into from
Jun 20, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

This PR cleans up a bunch of version handling code in the application, and RPCs.

Solution

Related fixes:

Review

This is a low priority cleanup.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ A-network Area: Network protocol updates or fixes A-diagnostics Area: Diagnosing issues or monitoring performance A-rpc Area: Remote Procedure Call interfaces labels Jun 19, 2023
@teor2345 teor2345 self-assigned this Jun 19, 2023
@teor2345 teor2345 requested review from a team as code owners June 19, 2023 00:13
@teor2345 teor2345 requested review from arya2 and removed request for a team June 19, 2023 00:13
@github-actions github-actions bot added C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #6996 (307be10) into main (0da2dcb) will decrease coverage by 0.05%.
The diff coverage is 72.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6996      +/-   ##
==========================================
- Coverage   77.49%   77.44%   -0.05%     
==========================================
  Files         310      310              
  Lines       41536    41539       +3     
==========================================
- Hits        32189    32171      -18     
- Misses       9347     9368      +21     

mergify bot added a commit that referenced this pull request Jun 20, 2023
@mergify mergify bot merged commit c3f0f53 into main Jun 20, 2023
@mergify mergify bot deleted the cleanup-versions branch June 20, 2023 02:42
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-network Area: Network protocol updates or fixes A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants