Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): Clean up licensing, closure move, log typos, tracing spans #6995

Merged
merged 8 commits into from
Jun 19, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

A bunch of minor zebra-network cleanups.

Solution

Review

This is a low priority fix, @arya2 asked for some of these.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ A-network Area: Network protocol updates or fixes C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-legal Area: Changes that could have legal impacts labels Jun 18, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 18, 2023 23:04
@teor2345 teor2345 self-assigned this Jun 18, 2023
@teor2345 teor2345 requested review from arya2 and removed request for a team June 18, 2023 23:04
@github-actions github-actions bot added the C-bug Category: This is a bug label Jun 18, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #6995 (1247b9e) into main (73ce8fb) will decrease coverage by 0.10%.
The diff coverage is 15.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6995      +/-   ##
==========================================
- Coverage   77.55%   77.45%   -0.10%     
==========================================
  Files         310      310              
  Lines       41582    41609      +27     
==========================================
- Hits        32248    32228      -20     
- Misses       9334     9381      +47     

Base automatically changed from fix-inbound-panic to main June 19, 2023 03:40
mergify bot added a commit that referenced this pull request Jun 19, 2023
@mergify mergify bot merged commit ad7af3e into main Jun 19, 2023
@mergify mergify bot deleted the cleanup-fix-inbound-panic branch June 19, 2023 18:17
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-legal Area: Changes that could have legal impacts A-network Area: Network protocol updates or fixes C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants