fix(panic): Stop panicking when handling inbound connection handshakes

[teor2345]

Motivation

In PR #6969 which just merged yesterday, I introduced a panic bug when handling some inbound handshake errors.

Complex Code or Requirements

The lack of FuturesUnordered types made bugs like this easy to add and tricky to catch.

Solution

• Fix the panic by handling errors directly on the futures
• Fix a potential panic on shutdown by logging when tasks are cancelled, rather than panicking unconditionally
• Prevent panics in other refactors by adding types to errors and FuturesUnordered

Related cleanups:

• Remove a redundant timeout in outbound handshakes

Review

This could be an urgent fix if it causes panics in other tests or full syncs.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[codecov]

Codecov Report

Merging #6984 (e000024) into main (1e12a58) will decrease coverage by 0.17%.
The diff coverage is 12.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6984      +/-   ##
==========================================
- Coverage   77.59%   77.43%   -0.17%     
==========================================
  Files         310      310              
  Lines       41536    41560      +24     
==========================================
- Hits        32231    32182      -49     
- Misses       9305     9378      +73     

[arya2]

This looks good, I left a few nitpicks.

[teor2345]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed