Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(release): Add more cargo clean to the release checklist #6964

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 14, 2023

Motivation

We should do the same steps for release preparation and the actual release.
It's good to have a record of all the tests done on the release.

Solution

  • add cargo clean to the release preparation steps
  • ask release manager to put the cargo install output on the PR
  • add --locked to the cargo install command

Review

This is a trivial update.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

Automate some of these steps.

@teor2345 teor2345 added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Low ❄️ labels Jun 14, 2023
@teor2345 teor2345 self-assigned this Jun 14, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 14, 2023 21:50
@teor2345 teor2345 requested review from dconnolly and removed request for a team June 14, 2023 21:50
@github-actions github-actions bot added C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 14, 2023
mergify bot added a commit that referenced this pull request Jun 16, 2023
@mergify mergify bot merged commit b199a30 into main Jun 16, 2023
@mergify mergify bot deleted the release-cargo-clean branch June 16, 2023 16:32
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants