Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep links within the zebra book whenever possible #6938

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

mpguerra
Copy link
Contributor

Motivation

There's a number of links in the README and the zebra book that refer back to files on github.com instead of the book itself. These should ideally remain in the zebra book.

Solution

Replace links out to github.com with their zebra.zfnd.org equivalents

Review

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@mpguerra mpguerra requested a review from a team as a code owner June 13, 2023 13:13
@mpguerra mpguerra requested review from upbqdn and removed request for a team June 13, 2023 13:13
@mpguerra mpguerra added A-docs Area: Documentation P-Low ❄️ labels Jun 13, 2023
@teor2345 teor2345 added do-not-merge Tells Mergify not to merge this PR P-Critical 🚑 C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG and removed P-Low ❄️ do-not-merge Tells Mergify not to merge this PR labels Jun 13, 2023
@teor2345
Copy link
Contributor

This seems like a low risk doc-only change that might be nice to have for new users after the stable release.

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jun 13, 2023
@mergify mergify bot merged commit 26313fa into main Jun 13, 2023
@mergify mergify bot deleted the pili-docs-updates branch June 13, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants