Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): Improve Dockerfile cache use by making build commands match exactly #6933

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 13, 2023

Motivation

I think Docker builds are slow because the cook and build/test commands are using different settings.

Solution

Use exactly the same settings for cook and build/test
Add a TODO for --locked once it is supported

Review

This is important but not a release blocker.

We might want to merge it separately to PR #6934, so we can see the cache speed improvement. The full speed improvement won't be visible until this PR merges to main.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-slow Problems with performance or responsiveness do-not-merge Tells Mergify not to merge this PR C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jun 13, 2023
@teor2345 teor2345 self-assigned this Jun 13, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 13, 2023 07:31
@teor2345 teor2345 requested review from arya2 and removed request for a team June 13, 2023 07:31
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree with merging this, I'm just not approving yet as I'd like to see how #6934 behaves without this changes.

@teor2345 teor2345 requested a review from gustavovalverde June 14, 2023 04:45
@dconnolly dconnolly removed the do-not-merge Tells Mergify not to merge this PR label Jun 14, 2023
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the dependency on PR #6934 as it will be more complex than initially expected

mergify bot added a commit that referenced this pull request Jun 14, 2023
@mergify mergify bot merged commit 912693b into main Jun 14, 2023
@mergify mergify bot deleted the fix-dockerfile-cache-use branch June 14, 2023 22:15
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants