fix(docker): Improve Dockerfile cache use by making build commands match exactly #6933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I think Docker builds are slow because the cook and build/test commands are using different settings.
Solution
Use exactly the same settings for cook and build/test
Add a TODO for --locked once it is supported
Review
This is important but not a release blocker.
We might want to merge it separately to PR #6934, so we can see the cache speed improvement. The full speed improvement won't be visible until this PR merges to
main
.Reviewer Checklist