fix(legal): Use correct licenses for tower-batch-control and zebra-network #6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
dconnolly
approved these changes
Jun 12, 2023
dconnolly
pushed a commit
that referenced
this pull request
Jun 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
* change(crates): Publish tower-batch-control * Cargo fields for zebra-test * Cargo fields for tower-fallback * Cargo fields for zebra-chain * Cargo fields for zebra-consensus * Cargo fields for zebra-network * Cargo fields for zebra-node-services * Cargo fields for zebra-rpc * Cargo fields for zebra-script * Cargo fields for zebra-state * Cargo fields for zebrad * Cargo fields for zebra-test * Include zebra-test version and path for zebra-chain * Include zebra-chain version and path for zebra-node-services * Include zebra-chain version and path for zebra-script * Include zebra-chain and zebra-test versions and paths for zebra-state * Include zebra-* versions and paths for zebra-consensus * Include zebra-* and tower-fallback versions and paths for tower-batch-control * Include tower-* versions and paths for zebra-consensus * Fixed tower-fallback license string * Remove versions for dev-dependencise * Update zebra-rpc/Cargo.toml Co-authored-by: teor <[email protected]> * tower-batch-control license MUST remain MIT only * Align zebra-network with upstream tower's MIT license * Update zebra-test/Cargo.toml Co-authored-by: teor <[email protected]> * Update zebra-utils/Cargo.toml Co-authored-by: teor <[email protected]> * fix(legal): Use correct licenses for tower-batch-control and zebra-network (#6927) * Don't modify whitespace * Resolve rustdoc and cargo-release warnings * Add missing zebra internal dependency versions * Workaround missing zebra-utils test dependency in zebrad test-only feature * Fix missing zebra internal dependency versions * Add README, home page, and search terms to every crate * Fix README publish warnings * Change tower crates to beta versions * Add zebra-utils to the list of allowed unused dependencies * Update tower-batch-control/Cargo.toml * Update tower-fallback/Cargo.toml --------- Co-authored-by: teor <[email protected]>
dconnolly
pushed a commit
that referenced
this pull request
Jun 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
* Include zebra-* and tower-fallback versions and paths for tower-batch-control * Remove versions for dev-dependencise * fix(legal): Use correct licenses for tower-batch-control and zebra-network (#6927) * Don't modify whitespace * Resolve rustdoc and cargo-release warnings * Bump semver * Re-up Cargo.lock * Update README.md Co-authored-by: teor <[email protected]> * Update book/src/user/docker.md Co-authored-by: teor <[email protected]> * Update 'Future Work' section post stable release * Add release notes to CHANGELOG.md * Update CHANGELOG.md Co-authored-by: teor <[email protected]> * Remove Docker container change from the changelog Co-authored-by: teor <[email protected]> * Point at the appropriate zebra-* crate versions * Update ESTIMATED_RELEASE_HEIGHT to 2,121,200 * Add CHANGELOG summary of the 1.0.0 release * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: teor <[email protected]> * Bump tower-* beta.* versions and use them --------- Co-authored-by: teor <[email protected]> Co-authored-by: Pili Guerra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some code in Zebra was copied from MIT-only open source projects.
Specifications
The licensing requirement from the MIT license text is:
https://github.com/tower-rs/tower/blob/bf4ea948346c59a5be03563425a7d9f04aadedf2/LICENSE#L13-L15
The required copyright notice is:
https://github.com/tower-rs/tower/blob/bf4ea948346c59a5be03563425a7d9f04aadedf2/LICENSE#LL1C1-L1C38
Solution
Legal requirements:
Other useful changes:
Review
@dconnolly is doing PR #6908.
Reviewer Checklist
Follow Up Work
I opened a ticket in the other developer's tower-batch fork, to let them know the license they copied is incorrect:
chmodas/tower-batch#15