fix(logs): Avoid grouping logs for separate tasks

[arya2]

Motivation

We've seen some malformed logs from the peer_cache_updater task:

2023-06-11T22:18:21.656595Z INFO {net="Test"}:accept_inbound_connections{min_inbound_peer_connection_interval=1s listener_addr=Ok(0.0.0.0:18233)}:listen_accept{peer=In("v4redacted:41812")}:crawl: zebra_network::peer_set::candidate_set: timeout waiting for peer service readiness or peer responses
accept_inbound_connections{min_inbound_peer_connection_interval=1s listener_addr=Ok(0.0.0.0:18233)}:listen_accept{peer=In("v4redacted:47028")}: zebra_network::config: updated cached peer IP addresses cached_ip_count=11 peer_cache_file="/root/.cache/zebra/network/testnet.peers

Solution

• Drop Entered guard in accept_inbound_connections() before yielding

Review

Anyone can review.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[codecov]

Codecov Report

Merging #6923 (40e74dc) into main (b10df28) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6923      +/-   ##
==========================================
- Coverage   77.60%   77.58%   -0.03%     
==========================================
  Files         310      310              
  Lines       41475    41475              
==========================================
- Hits        32188    32178      -10     
- Misses       9287     9297      +10     

[teor2345]

Thanks!

Looks like manual span handling is an anti-pattern, we should use the instrument macros on split-out functions instead.