Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Add fastmod --hidden to mass-renames.md #6913

Merged
merged 4 commits into from
Jun 15, 2023
Merged

fix(doc): Add fastmod --hidden to mass-renames.md #6913

merged 4 commits into from
Jun 15, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

Sometimes we want to rename things in .github as well as source code and docs.

Review

This is a low-priority developer doc fix.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-docs Area: Documentation P-Low ❄️ do-not-merge Tells Mergify not to merge this PR labels Jun 12, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 12, 2023 01:00
@teor2345 teor2345 self-assigned this Jun 12, 2023
@teor2345 teor2345 requested review from dconnolly and removed request for a team June 12, 2023 01:00
@github-actions github-actions bot added the C-feature Category: New features label Jun 12, 2023
@teor2345 teor2345 removed the do-not-merge Tells Mergify not to merge this PR label Jun 12, 2023
mergify bot added a commit that referenced this pull request Jun 12, 2023
@mergify
Merge of #6913
8b07704
@mergify mergify bot mentioned this pull request Jun 12, 2023
Closed
@teor2345 teor2345 added do-not-merge Tells Mergify not to merge this PR and removed C-feature Category: New features labels Jun 12, 2023
@github-actions github-actions bot added the C-feature Category: New features label Jun 12, 2023
@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

update

✅ Branch has been successfully updated

@dconnolly dconnolly removed the do-not-merge Tells Mergify not to merge this PR label Jun 14, 2023
mergify bot added a commit that referenced this pull request Jun 15, 2023
@mergify
Merge of #6913
2cba076
@mergify mergify bot mentioned this pull request Jun 15, 2023
Closed
@mergify mergify bot merged commit 98478c3 into main Jun 15, 2023
@mergify mergify bot deleted the doc-fastmod-hidden branch June 15, 2023 18:35
@teor2345 teor2345 mentioned this pull request Jun 28, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@gustavovalverde gustavovalverde gustavovalverde left review comments

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation C-bug Category: This is a bug C-feature Category: New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @dconnolly @gustavovalverde