-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): remove macOS tests from CI #6825
Conversation
I am a bit surprised, but my PR actually seems to fix the underlying bug: The test failures I saw were easy to fix. So let's leave this one in draft until we see if that one passes CI? |
That is even better, so yea, lets do that. |
Looks like my PR didn't work, let's try this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
I left the issue open because the bug isn't actually fixed, but I changed its priority to low.
Motivation
We have crashes in every PR after rust upgraded to 1.70 in macOS tests. We don't know what tests are causing it so we are disabling all tests for this platform as they are not supported by Zebra in tier 1.
Fixes the CI error in #6812, but not the underlying bug.
Solution
Remove all macOS tests from CI.
Review
Anyone can review.
Reviewer Checklist
Follow Up Work
Investigate whats going on and re enable if possible. #6824