-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace update_chain_state_with ref with update_chain_tip_with in rustdoc #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdoc Noted in the audit
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6781 +/- ##
==========================================
- Coverage 78.06% 77.92% -0.15%
==========================================
Files 308 308
Lines 40975 40975
==========================================
- Hits 31988 31929 -59
- Misses 8987 9046 +59 |
teor2345
reviewed
May 29, 2023
Co-authored-by: teor <[email protected]>
teor2345
reviewed
May 29, 2023
teor2345
previously approved these changes
May 29, 2023
teor2345
reviewed
May 30, 2023
teor2345
previously approved these changes
May 30, 2023
36 tasks
teor2345
approved these changes
May 31, 2023
Sorry for the messy commits here, it's actually tricky to reference a trait method from another module! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noted in the audit.
Solution
Update the rustdoc for
with_block_and_spent_utxos()
to mention the appropriateChain
method.Review
Reviewer Checklist