Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace update_chain_state_with ref with update_chain_tip_with in rustdoc #6781

Merged
merged 5 commits into from
May 31, 2023

Conversation

dconnolly
Copy link
Contributor

Motivation

Noted in the audit.

Solution

Update the rustdoc for with_block_and_spent_utxos() to mention the appropriate Chain method.

Review

Reviewer Checklist

  • Will the PR name make sense to users?
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?

@dconnolly dconnolly requested a review from a team as a code owner May 29, 2023 19:21
@dconnolly dconnolly requested review from upbqdn and removed request for a team May 29, 2023 19:21
@dconnolly dconnolly added A-docs Area: Documentation P-Low ❄️ labels May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #6781 (949a70b) into main (636dd42) will decrease coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6781      +/-   ##
==========================================
- Coverage   78.06%   77.92%   -0.15%     
==========================================
  Files         308      308              
  Lines       40975    40975              
==========================================
- Hits        31988    31929      -59     
- Misses       8987     9046      +59     

teor2345
teor2345 previously approved these changes May 29, 2023
teor2345
teor2345 previously approved these changes May 30, 2023
@teor2345 teor2345 added the C-audit Category: Issues arising from audit findings label May 30, 2023
@mpguerra mpguerra linked an issue May 30, 2023 that may be closed by this pull request
@mpguerra mpguerra mentioned this pull request May 30, 2023
36 tasks
@teor2345
Copy link
Contributor

Sorry for the messy commits here, it's actually tricky to reference a trait method from another module!

mergify bot added a commit that referenced this pull request May 31, 2023
@mergify mergify bot merged commit af4d531 into main May 31, 2023
@mergify mergify bot deleted the dconnolly-patch-1 branch May 31, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-audit Category: Issues arising from audit findings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Documentation in zebra-state
2 participants