fix(tests): Add an integration test for error conversions from zebra-state to zebra-consensus #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
added
C-enhancement
github-actions
bot
added
C-bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6665 +/- ##
==========================================
+ Coverage 77.98% 78.09% +0.11%
==========================================
Files 309 309
Lines 40664 40743 +79
==========================================
+ Hits 31711 31819 +108
+ Misses 8953 8924 -29 |
arya2
added
the
C-trivial
36 tasks
upbqdn
approved these changes
May 15, 2023
|
@mergify refresh |
✅ Pull request refreshed |
|
Another unrelated test failure: |
|
@Mergifyio refresh |
✅ Pull request refreshed |
This seems to be a peer failure, but maybe "all ready peers are missing inventory" shouldn't hang for 4 minutes before trying again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The transaction verifier in zebra-consensus converts and propagates boxed ValidateContextErrors from zebra-state, but is missing unit tests.
Closes #6399.
Solution
Review
Anyone can review.
Reviewer Checklist