-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(log): Report compiler version and Zebra features when starting Zebra #6606
Conversation
We have 3 different alternatives for checking the git metadata, I'm just doing some builds to check which one is the fastest to build. (It's probably the C library dependency, unfortunately!) |
Using So that's another potential issue. |
This PR with 33 seconds more user compile time This PR with 5 seconds less user compile time |
Manual testing: Before this PR, Zebra's startup logs have:
After this PR, they have:
The fields removed by vergen 8 are:
The new fields are:
The changed fields are:
But in most builds they are unchanged:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6606 +/- ##
==========================================
+ Coverage 77.87% 77.90% +0.02%
==========================================
Files 309 309
Lines 40665 40669 +4
==========================================
+ Hits 31669 31684 +15
+ Misses 8996 8985 -11 |
I'm going to bump this down to low priority because it doesn't need to go in the upcoming release. |
5607bbf
to
8247d38
Compare
Some of these might be from this PR, or the missed dependency updates.
8247d38
to
40e98ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Motivation
We want to report the compiler version when Zebra panics, and when it starts up. This helps us diagnose some bugs.
As part of this change, I updated the vergen version, because it changes how the compiler version works.
Close #5422
Close #6421
Specifications
API reference:
https://docs.rs/vergen/latest/vergen/index.html#usage
Complex Code or Requirements
This might break some of Zebra's existing version-handling code, which expects a semver-compliant version number.
It might also cause issues in PR #6601, which manually parses the version number.
Solution
Related changes:
.git
doesn't existTesting
See my manual testing here:
#6606 (comment)
Review
This is a routine change.
Reviewer Checklist