Add a timeout to the PeerServer event loop.
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #51 but the main event loop for the |
Closed
hdevalence
force-pushed
the
peer-request-timeout
branch
from
c7ec58a to
592b1e8
Compare
|
Going to try cleaning up the event loop a bit. |
hdevalence
force-pushed
the
peer-request-timeout
branch
from
e34c818 to
acb8848
Compare
|
Cleaned the event loop, removed the only other use of the |
I think this code could be cleaned up significantly (e.g., removing the other use of select!) but that's potentially a larger change than this PR.
hdevalence
force-pushed
the
peer-request-timeout
branch
from
00f6c73 to
e7f87d4
Compare
|
Rebased on top of |
dconnolly
reviewed
Oct 15, 2019
| Ok(new_state) => self.state = new_state, | ||
| Ok(new_state) => { | ||
| self.state = new_state; | ||
| self.request_timer = Some(delay_for(constants::REQUEST_TIMEOUT)); |
| None => return, | ||
| } | ||
| } | ||
| match future::select(shutdown_rx.next(), worker_rx.next()).await { |
hdevalence
commented
Oct 15, 2019
hdevalence
commented
Oct 15, 2019
|
Those renamings were incomplete, so I'm going to edit them locally, check they wrok, and update the branch |
Co-Authored-By: Henry de Valence <[email protected]>
hdevalence
force-pushed
the
peer-request-timeout
branch
from
956fbdf to
350d292
Compare
|
amended & updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this code could be cleaned up significantly (e.g., removing the
other use of select!) but that's potentially a larger change than this
PR.