Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): Disable issue URLs for a known shutdown panic in abscissa #6486

Merged
merged 3 commits into from
Apr 14, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ skip-tree = [
# wait for console-subscriber and tower to update hdrhistogram.
# also wait for ron to update insta, and wait for tonic update.
{ name = "base64", version = "=0.13.1" },

# wait for proptest's rusty-fork dependency to upgrade quick-error
{ name = "quick-error", version = "=1.2.3" },

Expand Down
10 changes: 7 additions & 3 deletions zebrad/src/application.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
//! Zebrad Abscissa Application

mod entry_point;
use self::entry_point::EntryPoint;

use std::{fmt::Write as _, io::Write as _, process};

use abscissa_core::{
Expand All @@ -18,6 +15,9 @@ use zebra_state::constants::{DATABASE_FORMAT_VERSION, LOCK_FILE_ERROR};

use crate::{commands::ZebradCmd, components::tracing::Tracing, config::ZebradConfig};

mod entry_point;
use entry_point::EntryPoint;

/// See <https://docs.rs/abscissa_core/latest/src/abscissa_core/application/exit.rs.html#7-10>
/// Print a fatal error message and exit
fn fatal_error(app_name: String, err: &dyn std::error::Error) -> ! {
Expand Down Expand Up @@ -309,10 +309,14 @@ impl Application for ZebradApp {
return false;
}

// Don't ask users to create bug reports for timeouts, duplicate blocks,
// full disks, or updated binaries.
oxarbitrage marked this conversation as resolved.
Show resolved Hide resolved
let error_str = error.to_string();
!error_str.contains("timed out")
&& !error_str.contains("duplicate hash")
&& !error_str.contains("No space left on device")
// abscissa panics like this when the running zebrad binary has been updated
&& !error_str.contains("error canonicalizing application path")
}
});

Expand Down