fix: Inconsistent Docs for Downloading ZKP Params

[upbqdn]

Motivation

Close #6340.

Solution

This PR:

• adjusts the implementation so that PARAMETER_DOWNLOAD_MAX_RETRIES is regarded as the max number of retries instead of attempts;
• removes the prefix retry_ from functions that download the parameters;
• cleans up the docs a bit.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[codecov]

Codecov Report

Merging #6464 (f2f4a53) into main (83eb845) will increase coverage by 0.13%.
The diff coverage is 50.00%.

❗ Current head f2f4a53 differs from pull request most recent head 4208704. Consider uploading reports for the commit 4208704 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6464      +/-   ##
==========================================
+ Coverage   77.75%   77.89%   +0.13%     
==========================================
  Files         304      304              
  Lines       39681    39678       -3     
==========================================
+ Hits        30855    30906      +51     
+ Misses       8826     8772      -54     

[arya2]

This looks great, thank you!

I may remember us saying we want to keep these as *_RETRIES and update the code to make retries + 1 attempts for fixes to this finding (e.g. PR #6460), but I'm not sure and that's not a blocker in any case.

[upbqdn]

I may remember us saying we want to keep these as *_RETRIES and update the code to make retries + 1 attempts for fixes to this finding (e.g. PR #6460)

Thanks for pointing that out, I wasn't aware of that. I switched back to retries, adjusted the code, and edited the PR description.

[arya2]

Thank you for making the change to retries!