fix(network): validate addr length before reading #6320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to validate addr length before reading and deserializing the addr itself.
Close #6280
Solution
There is a
sizeAddr
field in the spec that we can use first to validate. Then we usezcash_deserialize_bytes_external_count
to read the address with the length we already have.Review
Not sure if there is a better alternative. Anyone can review.
We already have tests for this, for example
parses_msg_addr_v2_ip
.Reviewer Checklist
Follow Up Work