Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(format): improve CommitBlockError message: include underlying ValidateContextError message #6251

Merged
merged 2 commits into from
Mar 2, 2023
Merged

change(format): improve CommitBlockError message: include underlying ValidateContextError message #6251

merged 2 commits into from
Mar 2, 2023

Conversation

teor2345
Copy link
Contributor

This is a copy of PR #6236 in the Zebra repository, so all our CI can run on it.

@teor2345 teor2345 added A-rust Area: Updates to Rust code P-Optional ✨ A-network Area: Network protocol updates or fixes A-diagnostics Area: Diagnosing issues or monitoring performance labels Feb 28, 2023
@teor2345 teor2345 requested a review from a team as a code owner February 28, 2023 19:47
@teor2345 teor2345 self-assigned this Feb 28, 2023
@teor2345 teor2345 requested review from dconnolly and removed request for a team February 28, 2023 19:47
@github-actions github-actions bot added the C-bug Category: This is a bug label Feb 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

⚠️ The sha of the head commit of this PR conflicts with #6236. Mergify cannot evaluate rules on this PR. ⚠️

@teor2345 teor2345 mentioned this pull request Feb 28, 2023
Closed
@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

refresh

✅ Pull request refreshed

@teor2345 teor2345 changed the title improve CommitBlockError message: include underlying ValidateContextError message change(format): improve CommitBlockError message: include underlying ValidateContextError message Feb 28, 2023
upbqdn
upbqdn previously approved these changes Feb 28, 2023
View reviewed changes
@upbqdn
Copy link
Member

upbqdn commented Feb 28, 2023

I can't approve this PR since I pushed it, even though I didn't make the commit.

@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #6251 (b28352f) into main (14fe014) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head b28352f differs from pull request most recent head 805c37d. Consider uploading reports for the commit 805c37d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6251      +/-   ##
==========================================
+ Coverage   78.00%   78.11%   +0.11%     
==========================================
  Files         304      304              
  Lines       39349    39349              
==========================================
+ Hits        30693    30737      +44     
+ Misses       8656     8612      -44

@teor2345
Copy link
Contributor Author

I can't approve this PR since I pushed it, even though I didn't make the commit.

If that rule gets annoying an admin can turn it off. But every time I've seen it come up, it's a situation where we actually want another review!

mergify bot added a commit that referenced this pull request Feb 28, 2023
@mergify
Merge of #6251
3321501
@mergify mergify bot mentioned this pull request Feb 28, 2023
Closed
@teor2345 teor2345 dismissed upbqdn’s stale review March 1, 2023 04:36

The last pusher can't review and approve PRs, it makes Mergify fail

@teor2345
Copy link
Contributor Author

teor2345 commented Mar 1, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

update

✅ Branch has been successfully updated

@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Mar 1, 2023
@mpguerra mpguerra linked an issue Mar 1, 2023 that may be closed by this pull request
Implement custom Debug trait for CommitBlockError #6218
Closed
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 2, 2023

Failed due to an infrastructure configuration issue, Gustavo is working on a fix.

To re-queue the PR, comment @mergify refresh once he's fixed it.

mergify bot added a commit that referenced this pull request Mar 2, 2023
@mergify
Merge of #6251
9895e72
@mergify mergify bot mentioned this pull request Mar 2, 2023
Closed
@mergify mergify bot merged commit f858aab into main Mar 2, 2023
@mergify mergify bot deleted the fix-commit-block-error-msg branch March 2, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpguerra mpguerra mpguerra approved these changes

@upbqdn upbqdn upbqdn left review comments

@dconnolly dconnolly Awaiting requested review from dconnolly dconnolly is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-network Area: Network protocol updates or fixes A-rust Area: Updates to Rust code C-bug Category: This is a bug C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement custom Debug trait for CommitBlockError
4 participants
@teor2345 @upbqdn @mpguerra @dimxy