Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Replace direct dependency on sentry-tracing with 'tracing' feature on sentry #6227

Merged
merged 1 commit into from
Feb 27, 2023
Merged

build(deps): Replace direct dependency on sentry-tracing with 'tracing' feature on sentry #6227

merged 1 commit into from
Feb 27, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Feb 24, 2023

Motivation

Dependabot updates for sentry-tracing are often coupled with the core sentry crate, which re-exports sentry-tracing if compiled with the 'tracing' feature.

We won't have to make manual updates to the dependabot PRs if we use sentry-tracing through the sentry crate.

Replaces #6225.

Solution

  • Add tracing feature to sentry crate
  • Update reference to use tracing layer through the sentry crate

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@arya2 arya2 requested review from a team as code owners February 24, 2023 20:38
@arya2 arya2 requested review from oxarbitrage and removed request for a team February 24, 2023 20:38
@github-actions github-actions bot added the C-feature Category: New features label Feb 24, 2023
@arya2 arya2 added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG and removed C-feature Category: New features labels Feb 24, 2023
@arya2 arya2 self-assigned this Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #6227 (7eedca7) into main (3ac019d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6227      +/-   ##
==========================================
- Coverage   77.85%   77.85%   -0.01%     
==========================================
  Files         304      304              
  Lines       39349    39349              
==========================================
- Hits        30637    30636       -1     
- Misses       8712     8713       +1

teor2345
teor2345 approved these changes Feb 26, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mergify bot added a commit that referenced this pull request Feb 26, 2023
@mergify
Merge of #6227
2a88400
@mergify mergify bot mentioned this pull request Feb 26, 2023
Closed
@teor2345
Copy link
Contributor

Failed in the merge queue with an invalid downloaded PGP key. This appears to be an issue with some Google mirrors.

https://github.com/ZcashFoundation/zebra/actions/runs/4277522877/jobs/7446388822#step:9:748

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Feb 27, 2023
@mergify
Merge of #6227
9f38982
@mergify mergify bot mentioned this pull request Feb 27, 2023
Closed
@teor2345
Copy link
Contributor

Failed in the merge queue with an invalid downloaded PGP key. This appears to be an issue with some Google mirrors.

https://github.com/ZcashFoundation/zebra/actions/runs/4277522877/jobs/7446388822#step:9:748

Still happening, but some PRs like #6217 are succeeding, possibly due to cached valid keys:
https://github.com/ZcashFoundation/zebra/actions/runs/4278743836/jobs/7448766228

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Feb 27, 2023
@mergify
Merge of #6227
78eed2e
@mergify mergify bot mentioned this pull request Feb 27, 2023
Closed
@teor2345 teor2345 mentioned this pull request Feb 27, 2023
Merged
@mergify mergify bot merged commit 5f10af4 into main Feb 27, 2023
@mergify mergify bot deleted the rm-sentry-tracing branch February 27, 2023 22:26
@oxarbitrage oxarbitrage mentioned this pull request Mar 23, 2023
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/network-reviewers

Assignees

@arya2 arya2

Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arya2 @teor2345