-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): Remove unused dependencies, and check for them in CI #6216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Category: This is a bug
A-dependencies
Area: Dependency file updates
A-devops
Area: Pipelines, CI/CD and Dockerfiles
P-Low ❄️
C-security
Category: Security issues
labels
Feb 24, 2023
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Feb 24, 2023
teor2345
changed the title
Check unused deps
fix(deps): Remove unused dependencies, and check for them in CI
Feb 24, 2023
teor2345
removed
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
C-removed
labels
Feb 24, 2023
github-actions
bot
added
C-removed
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
Feb 24, 2023
teor2345
removed
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
C-removed
labels
Feb 24, 2023
github-actions
bot
added
C-removed
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
Feb 24, 2023
6 tasks
This seems to work:
https://github.com/ZcashFoundation/zebra/actions/runs/4260322630/jobs/7413377013#step:5:20 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6216 +/- ##
==========================================
+ Coverage 77.94% 77.97% +0.03%
==========================================
Files 304 304
Lines 39349 39349
==========================================
+ Hits 30672 30684 +12
+ Misses 8677 8665 -12 |
arya2
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
teor2345
removed
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-dependencies
Area: Dependency file updates
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-bug
Category: This is a bug
C-security
Category: Security issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having unused dependencies makes Zebra less secure. It also increases build time and binary size.
We deleted a lot of code recently, but we didn't delete the dependencies that were only used by that code. We also copy-pasted some dependencies that weren't actually needed.
Closes #6215
Complex Code or Requirements
This has a bit of shell script in it, but it doesn't do anything unusual.
Solution
cargo-machete
This PR should appear in the changelog because it removes dependencies, which is visible to users.
Review
This is a low priority change. It can go in after the release.
Reviewer Checklist
Follow Up Work
After this PR merges, an admin should make the new job part of the branch protection rules.