Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Increase macOS CI timeout #6176

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix(ci): Increase macOS CI timeout #6176

merged 1 commit into from
Feb 17, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 16, 2023 •
edited by arya2
Loading

Motivation

When macOS refreshes the Zcash parameter cache, its CI sometimes takes longer than 165 minutes:
https://github.com/ZcashFoundation/zebra/actions/runs/4188656916/jobs/7260060480

(This one timed out in the last step, so it appears successful, but fails the PR.)

Review

This might be urgent if the cache was not actually written, because the next PR will do the same thing.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures labels Feb 16, 2023
@teor2345 teor2345 requested a review from a team as a code owner February 16, 2023 07:45
@teor2345 teor2345 self-assigned this Feb 16, 2023
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team February 16, 2023 07:45
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 16, 2023
@teor2345 teor2345 mentioned this pull request Feb 16, 2023
Merged
arya2
arya2 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/workflows/continous-integration-os.yml Show resolved Hide resolved
mergify bot added a commit that referenced this pull request Feb 17, 2023
@mergify
Merge of #6176
36f6070
@mergify mergify bot mentioned this pull request Feb 17, 2023
Closed
@mergify mergify bot merged commit bf80786 into main Feb 17, 2023
@mergify mergify bot deleted the ci-os-timeout branch February 17, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde gustavovalverde is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @arya2