Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump hyper from 0.14.23 to 0.14.24, fixing a denial of service risk #6094

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 2, 2023

Bumps hyper from 0.14.23 to 0.14.24.

Release notes

Sourced from hyper's releases.

v0.14.24

Bug Fixes

  • body: set an internal max to reserve in to_bytes (4d89adce)
  • server: prevent sending 100-continue if user drops request body (#3138) (92443d7e)

Features

  • http2: add http2_max_header_list_size to hyper::server::Builder (#3006) (031425f0)

New Contributors

Changelog

Sourced from hyper's changelog.

v0.14.24 (2023-02-02)

Bug Fixes

  • body: set an internal max to reserve in to_bytes (4d89adce)
  • server: prevent sending 100-continue if user drops request body (#3138) (92443d7e)

Features

  • http2: add http2_max_header_list_size to hyper::server::Builder (#3006) (031425f0)
Commits
  • 40c01df v0.14.24
  • 92443d7 fix(server): prevent sending 100-continue if user drops request body (#3138)
  • 4d89adc fix(body): set an internal max to reserve in to_bytes
  • 031425f feat(http2): add http2_max_header_list_size to hyper::server::Builder (#3...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [hyper](https://github.com/hyperium/hyper) from 0.14.23 to 0.14.24.
- [Release notes](https://github.com/hyperium/hyper/releases)
- [Changelog](https://github.com/hyperium/hyper/blob/v0.14.24/CHANGELOG.md)
- [Commits](hyperium/hyper@v0.14.23...v0.14.24)

---
updated-dependencies:
- dependency-name: hyper
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner February 2, 2023 16:01
@dependabot dependabot bot requested review from upbqdn and removed request for a team February 2, 2023 16:01
@dependabot dependabot bot added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #6094 (f26c143) into main (dc43dca) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6094      +/-   ##
==========================================
- Coverage   78.04%   78.01%   -0.03%     
==========================================
  Files         304      304              
  Lines       39027    39027              
==========================================
- Hits        30459    30448      -11     
- Misses       8568     8579      +11     

@teor2345 teor2345 added P-Medium ⚡ C-security Category: Security issues and removed P-Low ❄️ labels Feb 5, 2023
@teor2345 teor2345 changed the title build(deps): bump hyper from 0.14.23 to 0.14.24 build(deps): bump hyper from 0.14.23 to 0.14.24, fixing a denial of service risk Feb 5, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a remotely-triggerable memory denial of service in HTTP downloads. We're using minreq for our parameter downloads from trusted HTTPS servers. So this could only happen with an exposed metrics or RPC port, and lightwalletd sits in front of our RPC ports in public deployments.

@teor2345 teor2345 removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 5, 2023
mergify bot added a commit that referenced this pull request Feb 5, 2023
@mergify mergify bot merged commit c4032e2 into main Feb 6, 2023
@mergify mergify bot deleted the dependabot/cargo/hyper-0.14.24 branch February 6, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-security Category: Security issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant