Get details from transaction differences in getrawmempool
#6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mempool part will not be executed if there are no differences so you need to execute it several times to catch a diff and then get the full data. For example: So here we have a transaction which is in zcashd but not in zebrad that we could investigate: The output also shows one of the transactions (b18063362e72717855d8df6e614bc9c1e75974f87e481822451e8fdfedf77c52) is big enough to fail being a command line argument to |
Here's how you can read the transaction data from a file, to fix that issue: zebra/zebra-utils/zcash-rpc-block-template-to-proposal Lines 197 to 201 in 00e7418 Each extra argument needs to be on its own line, in this case you just have one argument - the transaction data:
|
teor2345
reviewed
Jan 26, 2023
There was a problem hiding this comment.
This looks great, thanks for putting it together!
I have some suggestions for making the command-line argument changes more flexible and compatible with existing setups.
I also think we might need to get transaction data from zcashd to diagnose some mempool differences.
|
These changes look good, but I haven't tested them yet. |
teor2345
reviewed
Jan 31, 2023
teor2345
reviewed
Jan 31, 2023
|
I tested these changes using this shell script: SAME=0; while zcash-rpc-diff 28232 getrawmempool; do SAME=$((SAME + 1)); echo "$SAME identical mempools"; sleep 10; date; doneI found a difference, but it seems like Here is what I got, with some long data removed: Here is the full transaction data: |
teor2345
reviewed
Jan 31, 2023
teor2345
previously approved these changes
Jan 31, 2023
|
What I am getting on testnet from that script: |
teor2345
reviewed
Jan 31, 2023
|
Another difference from mainnet, Zebra had this transaction, This appears to be a timing issue, but I have attached the full transaction content in case we want to do further analysis. (I deleted an identical 3.6 MB transaction from |
|
Same for my third difference, looks like |
teor2345
added
P-Medium ⚡
C-testing
teor2345
added
the
A-compatibility
Co-authored-by: teor <[email protected]>
mpguerra
approved these changes
Feb 1, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We know there are differences sometimes in the zebrad mempool and the zcashd one. We want to know what are the differences by getting transaction content among other data (tx hash, height).
This is for #5935
Solution
Review
This has a problem. When a transaction is too big, the call to
decoderawtransactionwill fail withArgument list too long. This is an OS limitation and it seems not trivial to change the argument limit in linux, i am not sure ifzcash-cliaccepts a file as argument and if this can solve the problem. Researching alsoxargsbut unsure if will work either.The PR is a draft until i can fix that, ideas are welcome.
Reviewer Checklist
Follow Up Work