Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in some consensus rules #6012

Merged
merged 1 commit into from
Jan 21, 2023
Merged

fix typos in some consensus rules #6012

merged 1 commit into from
Jan 21, 2023

Conversation

conradoplg
Copy link
Collaborator

Motivation

This is small typo fix which can be important for people searching for the consensus rule by a part of its text (a.k.a. me some hours ago)

Specifications

Original text of the rule for reference:

image

Complex Code or Requirements

Solution

Review

This is super low priority, and comment-only, so we may want to just admin-merge it

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@conradoplg conradoplg requested review from a team as code owners January 20, 2023 18:59
@conradoplg conradoplg requested review from teor2345 and removed request for a team January 20, 2023 18:59
@github-actions github-actions bot added the C-bug Category: This is a bug label Jan 20, 2023
@conradoplg conradoplg added A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ and removed C-bug Category: This is a bug labels Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #6012 (c3648a1) into main (67194c4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6012      +/-   ##
==========================================
- Coverage   78.01%   78.00%   -0.02%     
==========================================
  Files         312      312              
  Lines       38997    38997              
==========================================
- Hits        30425    30421       -4     
- Misses       8572     8576       +4     

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Jan 21, 2023

A few jobs failing downloading protoc.

https://github.com/ZcashFoundation/zebra/actions/runs/3970485461/jobs/6806284735

I am retrying them, maybe resource was not temporally available.

mergify bot added a commit that referenced this pull request Jan 21, 2023
@mergify mergify bot merged commit 6199b12 into main Jan 21, 2023
@mergify mergify bot deleted the fix-comment-typos branch January 21, 2023 15:43
@oxarbitrage oxarbitrage mentioned this pull request Jan 29, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants