Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(actions): add a workflow to automatically add new Zebra issues to projects #6008

Merged
merged 5 commits into from
Jan 24, 2023
Merged

feat(actions): add a workflow to automatically add new Zebra issues to projects #6008

merged 5 commits into from
Jan 24, 2023

Conversation

mpguerra
Copy link
Contributor

@mpguerra mpguerra commented Jan 20, 2023 •
edited by gustavovalverde
Loading

Motivation

We might want to use github projects instead of zenhub.

Solution

We need to automatically add new issues to the relevant Github projects

Review

@gustavovalverde

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

I want to add more automation to automatically set various project fields e.g priority based on the priority labels

@mpguerra mpguerra requested a review from a team as a code owner January 20, 2023 11:51
@mpguerra mpguerra requested review from arya2 and removed request for a team January 20, 2023 11:51
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jan 20, 2023
arya2
arya2 reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I left a few suggestions for condensing the duplicate event trigger.

.github/project-management.yml Outdated Show resolved Hide resolved
.github/project-management.yml Outdated Show resolved Hide resolved
.github/project-management.yml Outdated Show resolved Hide resolved
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ labels Jan 23, 2023
@gustavovalverde gustavovalverde requested a review from a team as a code owner January 23, 2023 01:24
@gustavovalverde gustavovalverde changed the title Add job to automatically add new Zebra issues to projects feat(actions): add a workflow to automatically add new Zebra issues to projects Jan 23, 2023
@gustavovalverde gustavovalverde added the C-enhancement Category: This is an improvement label Jan 23, 2023
gustavovalverde
gustavovalverde approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets get it merged and test it

mergify bot added a commit that referenced this pull request Jan 23, 2023
@mergify
Merge of #6008
200b465
@mergify mergify bot mentioned this pull request Jan 23, 2023
Closed
@teor2345
Copy link
Contributor

teor2345 commented Jan 23, 2023 •
edited
Loading

This PR is causing a bug in Mergify, I have submitted a ticket.

The last PR batch got half-merged (which is a bug, but didn't cause any CI issues this time). As far as I can tell, the "must have approval from someone other than the last pusher" branch protection rule isn't checked consistently by Mergify (another bug). It seems to be checked before merge, but not while queueing.

Can we leave it alone until they get a chance to look at it overnight?

@gustavovalverde
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 23, 2023

update

✅ Branch has been successfully updated

teor2345
teor2345 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mergify has explained that GitHub doesn't have an API for the failing branch protection rule. So we might just have to live with the merge bug.

(Or not approve our own commits!)

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jan 24, 2023
@mergify
Merge of #6008
2b650fa
@mergify mergify bot mentioned this pull request Jan 24, 2023
Closed
@mergify mergify bot merged commit c92f7b0 into main Jan 24, 2023
@mergify mergify bot deleted the pili-pm-actions branch January 24, 2023 01:05
@oxarbitrage oxarbitrage mentioned this pull request Jan 29, 2023
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 left review comments

@gustavovalverde gustavovalverde gustavovalverde approved these changes

@teor2345 teor2345 teor2345 approved these changes

Assignees

@mpguerra mpguerra

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpguerra @teor2345 @gustavovalverde @arya2