Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Move docker push fix to the setup action #5998

Merged
merged 2 commits into from
Jan 19, 2023
Merged

fix(ci): Move docker push fix to the setup action #5998

merged 2 commits into from
Jan 19, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jan 19, 2023 •
edited by arya2
Loading

Motivation

  1. Move the workaround in buildx failed with: ERROR: failed to solve: failed to push ghcr.io/finchsec/kali:latest: failed to copy: io: read/write on closed pipe docker/build-push-action#761 (comment) to the setup workflow
  2. Apply the same workaround to the lightwalletd Docker push

Close #5958

Review

This is an urgent fix to stop CI failures.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jan 19, 2023
@teor2345 teor2345 requested a review from a team as a code owner January 19, 2023 01:15
@teor2345 teor2345 self-assigned this Jan 19, 2023
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team January 19, 2023 01:15
arya2
arya2 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@arya2 arya2 added the I-build-fail Zebra fails to build label Jan 19, 2023
@teor2345
Copy link
Contributor Author

Failed due to some temporary network errors downloading GitHub actions.

I'll retry the jobs now.

@mergify mergify bot mentioned this pull request Jan 19, 2023
Closed
@mergify mergify bot merged commit ddda4d0 into main Jan 19, 2023
@mergify mergify bot deleted the fix-docker-push-errors branch January 19, 2023 03:30
@gustavovalverde
Copy link
Member

Oops! Thanks for fixing this

@oxarbitrage oxarbitrage mentioned this pull request Jan 29, 2023
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde gustavovalverde is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-build-fail Zebra fails to build I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker push fails with "failed to copy: io: read/write on closed pipe"
3 participants
@teor2345 @gustavovalverde @arya2