-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpc): Return detailed errors to the RPC client when a block proposal fails #5993
Conversation
I tested this PR with I now see detailed errors like:
Rather than the same error every time:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5993 +/- ##
==========================================
+ Coverage 77.94% 77.98% +0.04%
==========================================
Files 312 312
Lines 38987 38995 +8
==========================================
+ Hits 30387 30410 +23
+ Misses 8600 8585 -15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Only change needed is an updated reference in the acceptance test for the renamed ErrorResponse
.
Motivation
We are currently testing Zebra's block templates in ticket #5803. But I can't work out if Zebra's errors are expected or the same as
zcashd
, because it doesn't return any error information at all.This PR changes the error handling from bug #5981, it probably gets us closer to a fix.
(But to match
zcashd
we'd need to stop pretty printing, and change the format of the error string.)Specifications
We can do whatever we like here, because bug #5981 will fix up any mining pool compatibility issues.
Solution
Review
This seems like a high priority because testing is difficult without it.
Reviewer Checklist