fix(deps): Add test dependency from zebra-rpc to zebra-network with correct features #5992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5992 +/- ##
==========================================
- Coverage 78.03% 78.02% -0.01%
==========================================
Files 312 312
Lines 38995 38995
==========================================
- Hits 30430 30427 -3
- Misses 8565 8568 +3 |
|
Failed with: Iam restarting the failed check. |
oxarbitrage
approved these changes
Jan 18, 2023
PR #5985 fixes this issue, it might not have merged when I pushed this branch. |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio refresh |
|
Hopefully this should merge now that we've fixed that CI Docker bug |
✅ Pull request refreshed |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If I build the tests for the individual
zebra-rpccrate, the build fails due to a missing dependency.This is a bug from PR #5951.
Solution
Add the correct dependencies for the
proptest-implfeature.Review
Anyone can review this code. It blocks some kinds of testing, so I think it might be a high priority.
Reviewer Checklist
Follow Up Work
I don't think we need any extra CI checks for this build bug, because it just happens in test code.