Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(doc): Update PR template #5988

Merged
merged 1 commit into from
Jan 18, 2023
Merged

change(doc): Update PR template #5988

merged 1 commit into from
Jan 18, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jan 18, 2023

Motivation

We discussed changes to the template in the retrospective.

Solution

  • Adds a note to list commits of key functional changes for large PRs

Review

Anyone can review.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@arya2 arya2 added A-docs Area: Documentation P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jan 18, 2023
@arya2 arya2 requested a review from a team as a code owner January 18, 2023 00:20
@arya2 arya2 self-assigned this Jan 18, 2023
@arya2 arya2 requested review from teor2345 and removed request for a team January 18, 2023 00:20
@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Jan 18, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Anyone can suggest further changes in another PR.

mergify bot added a commit that referenced this pull request Jan 18, 2023
@mergify mergify bot merged commit 5f0d5f6 into main Jan 18, 2023
@mergify mergify bot deleted the update-pr-template branch January 18, 2023 02:23
@oxarbitrage oxarbitrage mentioned this pull request Jan 29, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants