change(ci): Run block proposal tests in CI

[teor2345]

Motivation

We want to use getblocktemplate in proposal mode in the acceptance test to check that it's producing valid templates.

Depends-On: #6027

Closes #5685

Complex Code or Requirements

We want to manually test that block proposals work before merging this automated test.

We need to fix all known block proposal and mempool bugs before running this test in CI.

Solution

• Test all possible valid times in block proposals (min, proposal current, max, and current clamped to [min, max])
• Run block proposal tests as part of the existing block template test in CI

Review

Anyone can review this PR.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[teor2345]

That was a bad merge, let's see how this one goes

[codecov]

Codecov Report

Merging #5963 (34cba9d) into main (e20cf95) will decrease coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5963      +/-   ##
==========================================
- Coverage   78.25%   78.09%   -0.16%     
==========================================
  Files         312      312              
  Lines       39418    39418              
==========================================
- Hits        30846    30785      -61     
- Misses       8572     8633      +61     

[teor2345]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[teor2345]

@Mergifyio update

[mergify]

update

☑️ Nothing to do

• #commits-behind>0 [:pushpin: update requirement]
• -closed [:pushpin: update requirement]

[arya2]

🔥

Thank you!

Update: we need another approver because I was the last pusher (it needed a rebase).

[teor2345]

🔥

Thank you!

Update: we need another approver because I was the last pusher (it needed a rebase).

I can't approve because I opened the PR, so it will have to be @oxarbitrage

[teor2345]

🔥
Thank you!
Update: we need another approver because I was the last pusher (it needed a rebase).

I can't approve because I opened the PR, so it will have to be @oxarbitrage or @dconnolly

If this is more annoying than it's worth, maybe we can disable this rule? Did you want to talk about it at the engineering sync?

[arya2]

If this is more annoying than it's worth, maybe we can disable this rule? Did you want to talk about it at the engineering sync?

It doesn't happen very often so I don't mind, and tagging Pili seems like a good solution for next time. I'll ask about review-latency in the next sync though because that could use some improvement.

[teor2345]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[teor2345]

Codespell failed due to a network error, but it's not required to merge.