Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(deps): Remove unused zebra-utils dependencies #5961

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

zebra-utils only uses some constants from zebra-state, but it depends on the whole of zebra-state. (Including rocksdb and other large dependencies.)

It is much faster to compile the utilities if we minimise their dependencies. It also makes them easier to maintain and secure.

This is blocking RPC testing.

Solution

Move some state constants into zebra-node-services, and update the corresponding dependency files and imports.

Review

This is blocking RPC testing, it is a bit urgent.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-High 🔥 A-rpc Area: Remote Procedure Call interfaces labels Jan 16, 2023
@teor2345 teor2345 requested review from a team as code owners January 16, 2023 00:26
@teor2345 teor2345 self-assigned this Jan 16, 2023
@teor2345 teor2345 requested review from arya2 and removed request for a team January 16, 2023 00:26
@github-actions github-actions bot added C-enhancement Category: This is an improvement C-removed labels Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #5961 (3c6bf93) into main (99a2da6) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5961      +/-   ##
==========================================
+ Coverage   78.06%   78.12%   +0.05%     
==========================================
  Files         311      311              
  Lines       38919    38919              
==========================================
+ Hits        30384    30405      +21     
+ Misses       8535     8514      -21     

Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for splitting this into its own PR!

mergify bot added a commit that referenced this pull request Jan 16, 2023
@mergify mergify bot merged commit c2896cc into main Jan 16, 2023
@mergify mergify bot deleted the remove-unused-utils-deps branch January 16, 2023 21:39
@oxarbitrage oxarbitrage mentioned this pull request Jan 29, 2023
36 tasks
teor2345 added a commit that referenced this pull request Feb 6, 2023
… merge: git cherry-pick --strategy=ort --strategy-option=theirs c2896cc

* Remove unused zebra-utils dependencies

* Cleanup zebra-checkpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants