fix(diagnostics): Hex-encode debug format of commitments, nonces, and nullifiers #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
6 tasks
teor2345
changed the title
teor2345
force-pushed
the
hex-debug
branch
2 times, most recently
from
76c8377 to
432b680
Compare
|
Looks like crates.io is having some network or capacity issues, I'll retry those parts of CI later. (Or anyone can do it if I'm not around.) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5960 +/- ##
==========================================
- Coverage 78.11% 78.03% -0.09%
==========================================
Files 312 312
Lines 38936 38988 +52
==========================================
+ Hits 30414 30423 +9
- Misses 8522 8565 +43 |
arya2
changed the title
|
@Mergifyio refresh |
|
Failed with bug #5958 in the merge queue: |
✅ Pull request refreshed |
|
It looks like this has a build conflict with some code in other PRs, I'll see what I can do to fix it. |
conradoplg
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra's debug output shows block header commitments and nonces as an array of integers, rather than hexadecimal. This makes them very hard to debug.
This diagnostics bug is impacting RPC testing.
Most of the changes in this PR are in test code, or they are tiny changes to existing code.
Solution
HexDebugtype wrapper, which automatically makes the wrapped type encode as hex duringderive(Debug)I also opened ticket ZcashFoundation/redjubjub#155 to make similar changes in
redjubjub.Review
This is blocking RPC testing, it is important to review soon.
Reviewer Checklist