Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clippy): Fix new lints in nightly clippy #5959

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jan 15, 2023

Motivation

We regularly fix new clippy lints to make new Rust releases easier to upgrade to, and to make Zebra easier to maintain.

Solution

  • derive Default in more places
  • implement PartialEq manually when Hash is implemented manually
  • document some functions to resolve missing docs warnings in Docker builds

Review

Anyone can review this PR, it is a low priority.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ A-diagnostics Area: Diagnosing issues or monitoring performance labels Jan 15, 2023
@teor2345 teor2345 requested a review from a team as a code owner January 15, 2023 23:53
@teor2345 teor2345 self-assigned this Jan 15, 2023
@teor2345 teor2345 requested review from a team as code owners January 15, 2023 23:53
@teor2345 teor2345 requested review from dconnolly and oxarbitrage and removed request for a team January 15, 2023 23:53
@github-actions github-actions bot added C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jan 15, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #5959 (e5985ea) into main (99a2da6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head e5985ea differs from pull request most recent head 577cd7b. Consider uploading reports for the commit 577cd7b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5959      +/-   ##
==========================================
+ Coverage   78.06%   78.11%   +0.04%     
==========================================
  Files         311      311              
  Lines       38919    38914       -5     
==========================================
+ Hits        30384    30398      +14     
+ Misses       8535     8516      -19     

@teor2345 teor2345 removed the request for review from a team January 16, 2023 20:36
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the proactive fixes!

zebra-chain/src/orchard/tree.rs Show resolved Hide resolved
zebra-chain/src/orchard/tree.rs Show resolved Hide resolved
mergify bot added a commit that referenced this pull request Jan 17, 2023
mergify bot added a commit that referenced this pull request Jan 17, 2023
@mergify mergify bot merged commit 256b1c0 into main Jan 18, 2023
@mergify mergify bot deleted the clippy-2023-01-16 branch January 18, 2023 00:27
@oxarbitrage oxarbitrage mentioned this pull request Jan 29, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants