-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: reduce the amount of API calls made by arduino/setup-protoc@v1
#5930
Conversation
If the `protoc` compiler version is not available locally, the action will look for the most recent version. We use a fixed version to reduce the amount of API calls being done in all workflows, but mainly on `build-crates-individually.yml`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right, but the updated steps seem to fail:
Error: unable to get latest version
https://github.com/ZcashFoundation/zebra/actions/runs/3875142251/jobs/6607275825#step:3:13
Oh, that's odd. That version actually exists. I'll update this with a lower version and see how it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hopefully arduino/setup-protoc will work with later versions of protoc soon.
Motivation
Every few days, multiple PRs will fail with GitHub "API rate-limit exceeded" errors. These errors seem to happen when there are multiple pushes to a PR within a short period of time.
Fixes #5819
Solution
If the
protoc
compiler version is not available locally, the action will look for the most recent version. We use a fixed version to reduce the amount of API calls being done in all workflows, but mainly onbuild-crates-individually.yml
Note: A recent update on
bump tj-actions/changed-files
also reduced the amount of API calls, based on our actual fetch configuration.Review
Anyone can review this
Reviewer Checklist
Follow Up Work