fix(ci): remove warnings caused by missing actions/checkout step

[gustavovalverde]

Motivation

We get this warning when running the continous-delivery.yml workflow:

Deploy single instance
The "create_credentials_file" option is true, but the current GitHub workspace is empty. Did you forget to use "actions/checkout" before this step? If you do not intend to share authentication with future steps in this job, set "create_credentials_file" to false.

Fixes #5729

Solution

Add missing actions/checkout steps to allow the credentials file to be written correctly

Review

Anyone can review this

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[arya2]

Running the workflow here: https://github.com/ZcashFoundation/zebra/actions/runs/3734154152

[arya2]

WARNING: Default device-name for disk name [auto-delete=yes] will be [auto-delete=yes] because it is being mounted to a container with [--container-mount-disk]
ERROR: (gcloud.compute.instances.create-with-container) Could not fetch resource:

• Invalid value for field 'resource.disks[1].deviceName': 'auto-delete=yes'. Must be a match of regex '(^$|\w[\w.-]{0,254})'

https://github.com/ZcashFoundation/zebra/actions/runs/3734154152/jobs/6335869442#step:6:74

[arya2]

WARNING: Default device-name for disk name [auto-delete=yes] will be [auto-delete=yes] because it is being mounted to a container with [--container-mount-disk]
ERROR: (gcloud.compute.instances.create-with-container) Could not fetch resource:

• Invalid value for field 'resource.disks[1].deviceName': 'auto-delete=yes'. Must be a match of regex '(^$|\w[\w.-]{0,254})'

https://github.com/ZcashFoundation/zebra/actions/runs/3734154152/jobs/6335869442#step:6:74

@gustavovalverde I don't see why this PR would cause this issue, but it's not happening on the main branch or anywhere else.

[teor2345]

WARNING: Default device-name for disk name [auto-delete=yes] will be [auto-delete=yes] because it is being mounted to a container with [--container-mount-disk]
ERROR: (gcloud.compute.instances.create-with-container) Could not fetch resource:

• Invalid value for field 'resource.disks[1].deviceName': 'auto-delete=yes'. Must be a match of regex '(^$|\w[\w.-]{0,254})'

https://github.com/ZcashFoundation/zebra/actions/runs/3734154152/jobs/6335869442#step:6:74

@gustavovalverde I don't see why this PR would cause this issue, but it's not happening on the main branch or anywhere else.

This seems to be an existing bug in the workflow, which is only triggered by a workflow_dispatch.

The name= field is missing for manual dispatch:

zebra/.github/workflows/continous-delivery.yml

Line 220 in 53e836e

--create-disk=name=auto-delete=yes,size=300GB,type=pd-ssd \

This is what it should be like:

zebra/.github/workflows/continous-delivery.yml

Line 139 in 53e836e

--create-disk=name=zebrad-cache-${{ env.GITHUB_SHA_SHORT }},auto-delete=yes,size=300GB,type=pd-ssd \

This seems like a blocker for this PR, because we can't test the PR without fixing it.

[gustavovalverde]

Working once again https://github.com/ZcashFoundation/zebra/actions/runs/3877453287/jobs/6612495110

[teor2345]

Is this warning a problem?

WARNING: Default device-name for disk name [None] will be [None] because it is being mounted to a container with [--container-mount-disk]

https://github.com/ZcashFoundation/zebra/actions/runs/3877453287/jobs/6612495110#step:6:75

[teor2345]

Looks good otherwise!

[gustavovalverde]

Is this warning a problem?

That's part of the issues with the GCP documentation that I reported to them