feat(ci): delete unused artifacts in registries

[gustavovalverde]

Previous behavior:

Docker artifacts are costing us a good part of our infrastructure budget, and we needed a way to remove unused artifacts.

Expected behavior:

Delete unused (not just old) docker artifacts in GAR (Google Artifact Registry), preferably using a generic solution is this needs to be expanded into other Docker registries.

Solution:

Implement GCR Cleaner https://github.com/GoogleCloudPlatform/gcr-cleaner, as this tools provided integration with docker/login-action to interact with multiple Docker v2 registries.

Fixes #5750

Review

Anyone can review, just have to wait for manual execution to validate it's working

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[gustavovalverde]

Test run available here: https://github.com/ZcashFoundation/zebra/actions/runs/3732040969/jobs/6330968018

[arya2]

Test run available here: https://github.com/ZcashFoundation/zebra/actions/runs/3732040969/jobs/6330968018

Some of the deletions failed:

• failed to delete digest us-docker.pkg.dev/zealous-zebra/zebra/lightwalletd@sha256:001e448ab8c82848f015a6ccbca8bffdd6a8cde73d856256e326511e54483e8c: DELETE https://us-docker.pkg.dev/v2/zealous-zebra/zebra/lightwalletd/manifests/sha256:001e448ab8c82848f015a6ccbca8bffdd6a8cde73d856256e326511e54483e8c: GOOGLE_MANIFEST_DANGLING_PARENT_IMAGE: Manifest is still referenced by one or more parent images

https://github.com/ZcashFoundation/zebra/actions/runs/3732040969/jobs/6330968018#step:6:183

[gustavovalverde]

This is happening even when trying to do it manually on those digests, I'm trying to find the root-cause.

[teor2345]

Looks great, thanks for this!

This is happening even when trying to do it manually on those digests, I'm trying to find the root-cause.

I think it's ok for us to delete most of the outdated images, and ignore any errors for now. Then if we end up with a lot of images we can't delete, we can investigate further.

(And sometimes the deletes will work the second time, because we've deleted the images that were depending on those images.)

[teor2345]

Looks good!

I ran the workflow manually and it returned an error:

us-docker.pkg.dev/zealous-zebra/zebra/zebrad-test
2 errors occurred:
✗ no refs were deleted

• failed to delete digest sha256:f9d25e9a3b5d405e120767afd82197674caa392bd7fb3f5f7ae0397457442a60: DELETE https://us-docker.pkg.dev/v2/zealous-zebra/zebra/lightwalletd/manifests/sha256:f9d25e9a3b5d405e120767afd82197674caa392bd7fb3f5f7ae0397457442a60: MANIFEST_UNKNOWN: Manifest not found: sha256:f9d25e9a3b5d405e120767afd82197674caa392bd7fb3f5f7ae0397457442a60
• failed to delete digest sha256:f9f02b652de4726fc8e133e489300ccf13a2823b03eb5c572e53e94848ecc1b7: DELETE https://us-docker.pkg.dev/v2/zealous-zebra/zebra/lightwalletd/manifests/sha256:f9f02b652de4726fc8e133e489300ccf13a2823b03eb5c572e53e94848ecc1b7: MANIFEST_UNKNOWN: Manifest not found: sha256:f9f02b652de4726fc8e133e489300ccf13a2823b03eb5c572e53e94848ecc1b7

https://github.com/ZcashFoundation/zebra/actions/runs/3888376395/jobs/6635625756#step:6:24

Can we set continue-on-error on the gcr-cleaner-cli step, until we fix these errors?
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error

[gustavovalverde]

I ran the action manually, and it's working.

[teor2345]

I ran the action manually, and it's working.

It looks like you ran the main branch action without these changes:
https://github.com/ZcashFoundation/zebra/actions/runs/3930069728

Here it is with the changes in this PR:
https://github.com/ZcashFoundation/zebra/actions/runs/3933727937

[teor2345]

Looks good to me, fixing the typo is optional.