Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nightly): Remove redundant track_caller which now causes errors on nightly #5839

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

Nightly Rust errors on #[track_caller] on async functions, which used to be silently ignored.

This is part of the actual implementation of that feature:
rust-lang/rust#87417

Solution

Remove #[track_caller] in places where it causes an error on nightly Rust.

Review

This is a low priority cleanup.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Low ❄️ labels Dec 11, 2022
@teor2345 teor2345 self-assigned this Dec 11, 2022
@teor2345 teor2345 requested a review from a team as a code owner December 11, 2022 21:29
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team December 11, 2022 21:29
@github-actions github-actions bot added C-bug Category: This is a bug C-removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Dec 11, 2022
@teor2345 teor2345 changed the title fix(nightly): Remove redundant track_callers which now cause errors on nightly fix(nightly): Remove redundant track_caller which now causes errors on nightly Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #5839 (dea3264) into main (f1e3fda) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5839      +/-   ##
==========================================
- Coverage   78.70%   78.69%   -0.02%     
==========================================
  Files         308      308              
  Lines       38786    38786              
==========================================
- Hits        30528    30522       -6     
- Misses       8258     8264       +6     

@teor2345 teor2345 removed C-removed C-bug Category: This is a bug labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants