fix(ci): Replace a spurious test failure with an info log #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with an info message
teor2345
added
C-bug
teor2345
added
the
C-trivial
dconnolly
approved these changes
Nov 30, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5753 +/- ##
==========================================
+ Coverage 78.74% 78.81% +0.07%
==========================================
Files 306 306
Lines 38687 38687
==========================================
+ Hits 30463 30492 +29
+ Misses 8224 8195 -29 |
|
This might be fixed by PR #5758, let's see! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This test is unreliable due to timing issues.
Closes #5384
Review
This is an urgent fix because it is failing on almost every PR.
Reviewer Checklist
Follow Up Work
We could fix the test, but we have other tests that cover this code already.