-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(rpc): generate coinbase transactions in the getblocktemplate RPC #5580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-dependencies
Area: Dependency file updates
A-consensus
Area: Consensus rule updates
C-enhancement
Category: This is an improvement
P-Medium ⚡
A-rpc
Area: Remote Procedure Call interfaces
labels
Nov 8, 2022
teor2345
requested review from
dconnolly and
oxarbitrage
and removed request for
a team
November 8, 2022 03:22
5 tasks
dconnolly
changed the title
change(rpc): Generate coinbase transactions in the getblocktemplate RPC
change(rpc): generate coinbase transactions in the getblocktemplate RPC
Nov 8, 2022
teor2345
force-pushed
the
gbt-coinbase-tx
branch
from
November 8, 2022 19:59
b899fb5
to
4907a75
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5580 +/- ##
==========================================
- Coverage 78.83% 78.78% -0.05%
==========================================
Files 305 305
Lines 38127 38160 +33
==========================================
+ Hits 30056 30064 +8
- Misses 8071 8096 +25 |
teor2345
force-pushed
the
gbt-coinbase-tx
branch
from
November 8, 2022 23:22
4907a75
to
6cbc9f9
Compare
oxarbitrage
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good.
arya2
reviewed
Nov 9, 2022
str4d
reviewed
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-consensus
Area: Consensus rule updates
A-dependencies
Area: Dependency file updates
A-rpc
Area: Remote Procedure Call interfaces
C-enhancement
Category: This is an improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR generates coinbase transactions when the
getblocktemplate
RPC is called.Solution
Generate the coinbase transaction in the getblocktemplate RPC:
Related changes:
Related fixes:
check_script_form()
so it is easier to readTesting:
Closes #5453.
Review
This is a routine change, it might help getting two people to review it.
Reviewer Checklist
Follow Up Work
I split #5579 out of #5453, because the state request wasn't ready yet.