-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3. change(rpc): Add fee and sigops fields to getblocktemplate transactions #5508
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5508 +/- ##
==========================================
- Coverage 78.91% 78.72% -0.20%
==========================================
Files 305 305
Lines 38061 38099 +38
==========================================
- Hits 30037 29993 -44
- Misses 8024 8106 +82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets try Arya suggestion at least for the one marked as allow(dead_code)
before merging.
Job failure but not a PR failure, see #5494 (comment) |
Co-authored-by: Alfredo Garcia <[email protected]>
0ce308a
to
985e2db
Compare
Motivation
We need to add a mempool query to get the
fee
andsigops
fields for thegetblocktemplate
RPC.Closes #5454
Depends-On: #5496
Specifications
https://zcash.github.io/rpc/getblocktemplate.html
And whatever
zcashd
does.Solution
FullTransactions
mempool requestVerifiedUnminedTx
with a newlegacy_sigop_count
fieldfee
andsigops
fields to the transaction templatesVerifiedUnminedTx
to the block header rootsReview
I think @oxarbitrage is reviewing this PR series, but anyone else can review it as well.
Reviewer Checklist
Follow Up Work
The rest of the
getblocktemplate
RPC, probably the coinbase transaction or state request next