-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add user documentation on how to use Zebra with docker #5504
Conversation
Motivation: We don't have a user documentation on how to use/deploy Zebra using our the Dockerfile available in our repository or were the images are being hosted Solution: Add user documentation explaining how to pull the image from the Docker Hub or how to build it locally. With extra information on which images we're hosting and where we're hosting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this!
I think we need to add the new document to the release checklist, and remove some duplicate Docker info in the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Let's also add a link to this page in the sidebar.
Co-authored-by: Arya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I fixed the merge conflict, happy to merge with or without my suggestion.
Co-authored-by: teor <[email protected]>
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated the new tags to rc.1, because PR #5513 is open, but it will merge after this PR.
@Mergifyio refresh |
✅ Pull request refreshed |
Motivation:
We don't have a user documentation on how to use/deploy Zebra using our the Dockerfile available in our repository or were the images are being hosted
Solution:
Add user documentation explaining how to pull the image from the Docker Hub or how to build it locally. With extra information on which images we're hosting and where we're hosting it
Motivation
Review
Anyone can review this
Reviewer Checklist
Follow Up Work
We should have easier deployment instructions for non-Docker users. Using something as https://github.com/GoogleCloudPlatform/cloud-run-button#cloud-run-button or https://github.com/GoogleCloudPlatform/click-to-deploy