Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. change(rpc): Add a mempool field to GetBlockTemplateRpcImpl, and cleanup tests #5493

Merged
merged 3 commits into from
Oct 28, 2022
Merged

1. change(rpc): Add a mempool field to GetBlockTemplateRpcImpl, and cleanup tests #5493

merged 3 commits into from
Oct 28, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 28, 2022 •
edited
Loading

Motivation

This PR adds a mempool field to GetBlockTemplateRpcImpl, and simplifies some tests.

Part of #5454.

Review

Anyone can review this PR.

These changes are likely to cause merge conflicts with other work, but the ticket is a medium priority.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

Get the transactions from the mempool.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement P-High 🔥 A-rpc Area: Remote Procedure Call interfaces C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 28, 2022
@teor2345 teor2345 self-assigned this Oct 28, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 28, 2022 00:28
@teor2345 teor2345 requested review from arya2 and removed request for a team October 28, 2022 00:28
@github-actions github-actions bot added the C-feature Category: New features label Oct 28, 2022
@teor2345 teor2345 added C-testing Category: These are tests and removed C-enhancement Category: This is an improvement C-feature Category: New features labels Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #5493 (134f624) into main (7b47aac) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5493      +/-   ##
==========================================
- Coverage   79.32%   79.21%   -0.11%     
==========================================
  Files         309      309              
  Lines       39348    39351       +3     
==========================================
- Hits        31211    31173      -38     
- Misses       8137     8178      +41

@github-actions github-actions bot added C-enhancement Category: This is an improvement C-feature Category: New features labels Oct 28, 2022
@teor2345 teor2345 changed the title change(rpc): Add a mempool to GetBlockTemplateRpcImpl, and cleanup tests 1. change(rpc): Add a mempool field to GetBlockTemplateRpcImpl, and cleanup tests Oct 28, 2022
@teor2345 teor2345 mentioned this pull request Oct 28, 2022
Merged
5 tasks
arya2
arya2 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for the cleanup!

mergify bot added a commit that referenced this pull request Oct 28, 2022
@mergify
Merge of #5493
d954543
@mergify mergify bot mentioned this pull request Oct 28, 2022
Closed
@mergify mergify bot merged commit 9cb3dbb into main Oct 28, 2022
@mergify mergify bot deleted the getblocktemplate-mempool branch October 28, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@teor2345 teor2345

Labels
A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-feature Category: New features C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @arya2