-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(state): Add block channel metrics, in preparation for block fork metrics #5327
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5327 +/- ##
==========================================
+ Coverage 79.16% 79.21% +0.04%
==========================================
Files 308 308
Lines 39752 39787 +35
==========================================
+ Hits 31470 31517 +47
+ Misses 8282 8270 -12 |
53801bb
to
c3d859d
Compare
This is a low-risk change that is not a release blocker. |
acd61c5
to
74b29be
Compare
c3d859d
to
f9ea36b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
These metrics are part of #5297, but we also needed them to diagnose bugs in PR #5257.
This is a low-risk change that is not a release blocker.
But we might want to merge it to improve sync diagnostics.
Solution
Review
This PR can merge by itself, it is not required to merge PR #5257.
Reviewer Checklist