Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Add a timeout to the non_blocking_logger test #5325

Merged
merged 4 commits into from
Oct 5, 2022
Merged

fix(test): Add a timeout to the non_blocking_logger test #5325

merged 4 commits into from
Oct 5, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 4, 2022 •
edited by dconnolly
Loading

Motivation

The non_blocking_logger test timed out on PR #5164 and produced 3 GB of logs:
https://github.com/ZcashFoundation/zebra/actions/runs/3177218716/jobs/5177415689

If that happens again, we want to end the test sooner, so the bug is easier to diagnose.

Review

Anyone can review this PR.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-Medium ⚡ I-heavy Problems with excessive memory, disk, or CPU usage I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 4, 2022
@teor2345 teor2345 self-assigned this Oct 4, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 4, 2022 00:07
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 4, 2022 00:07
@github-actions github-actions bot added the C-feature Category: New features label Oct 4, 2022
teor2345
teor2345 commented Oct 4, 2022
View reviewed changes
zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
@teor2345 teor2345 mentioned this pull request Oct 4, 2022
Merged
6 tasks
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #5325 (3f4c794) into main (9f6a1fd) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5325      +/-   ##
==========================================
+ Coverage   79.09%   79.13%   +0.03%     
==========================================
  Files         308      308              
  Lines       39560    39560              
==========================================
+ Hits        31291    31304      +13     
+ Misses       8269     8256      -13

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 4, 2022

Failed due to #5069:
https://github.com/ZcashFoundation/zebra/actions/runs/3178405970/jobs/5180280185#step:6:110

@teor2345
Copy link
Contributor Author

teor2345 commented Oct 4, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request Oct 4, 2022
@mergify
Merge of #5325
527472f
@mergify mergify bot mentioned this pull request Oct 4, 2022
Closed
mergify bot added a commit that referenced this pull request Oct 4, 2022
@mergify
Merge of #5325
3ac291b
@mergify mergify bot mentioned this pull request Oct 4, 2022
Closed
@gustavovalverde
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request Oct 5, 2022
@mergify
Merge of #5325
f994dcc
@mergify mergify bot mentioned this pull request Oct 5, 2022
Closed
@gustavovalverde
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Oct 5, 2022
@mergify
Merge of #5325
d1be781
@mergify mergify bot mentioned this pull request Oct 5, 2022
Closed
@mergify mergify bot merged commit 8a5708c into main Oct 5, 2022
@mergify mergify bot deleted the non-blocking-test-timeout branch October 5, 2022 21:45
@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

@mpguerra this bug was actually caused by PR #5032, it is unrelated to PR #4894.

@teor2345 teor2345 mentioned this pull request Oct 11, 2022
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-feature Category: New features C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-heavy Problems with excessive memory, disk, or CPU usage I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @gustavovalverde @dconnolly