-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. fix(rpc): Fix slow getblock RPC (verbose=1) using transaction ID index #5307
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5307 +/- ##
==========================================
- Coverage 79.15% 79.10% -0.05%
==========================================
Files 308 308
Lines 39479 39560 +81
==========================================
+ Hits 31248 31295 +47
- Misses 8231 8265 +34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this PR and it looks great to me. I am not approving as i am not assigned and someone else might have pending comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great.
Motivation
Zebra's
lightwalletd
sync takes a lot longer thanzcashd
's (7h vs 5h).Fixes #5298.
Solution
Use the transaction ID index for verbose
getblock
RPC requests, rather than deserializing the entire block, then hashing all the transactions in the block.Also add timing output to
zcash-rpc-diff
.Review
This is a routine fix.
Reviewer Checklist