change(state): Write non-finalized blocks to the state in a separate thread, to avoid network and RPC hangs

zebra-consensus/src/chain.rs

@@ -235,15 +235,7 @@ where
     let transaction = Buffer::new(BoxService::new(transaction), VERIFIER_BUFFER_BOUND);
 
     // block verification
-
-    let list = CheckpointList::new(network);
-
-    let max_checkpoint_height = if config.checkpoint_sync {
-        list.max_height()
-    } else {
-        list.min_height_in_range(network.mandatory_checkpoint_height()..)
-            .expect("hardcoded checkpoint list extends past canopy activation")
-    };
+    let (list, max_checkpoint_height) = init_checkpoint_list(config, network);
 
     let tip = match state_service
         .ready()
@@ -275,3 +267,20 @@ where
         max_checkpoint_height,
     )
 }
+
+/// Parses the checkpoint list for `network` and `config`.
+/// Returns the checkpoint list and maximum checkpoint height.
+pub fn init_checkpoint_list(config: Config, network: Network) -> (CheckpointList, Height) {
+    // TODO: Zebra parses the checkpoint list twice at startup.
+    //       Instead, cache the checkpoint list for each `network`.
+    let list = CheckpointList::new(network);
+
+    let max_checkpoint_height = if config.checkpoint_sync {
+        list.max_height()
+    } else {
+        list.min_height_in_range(network.mandatory_checkpoint_height()..)
+            .expect("hardcoded checkpoint list extends past canopy activation")
+    };
+
+    (list, max_checkpoint_height)
+}

zebra-consensus/src/checkpoint/test-checkpoints.txt

@@ -5085,3 +5085,87 @@
 2033600 00178c60cfd538584aab9e1a215f6e22c193f5f1c0bd984305be58d60ebbc799
 2034000 00da910d76185c236bb224b260d3302d747a08f4ee2e4445101c1dc107bbd8b0
 2034400 0091f576c32361d10617667c0d9be272b10c1d18d0df25304bff7a8572bb6044
+2034800 001e6a21fb50a3cacf988f90356b0366ff48a7ce24841c25d6f9267cafffa27a
+2035200 003300776534f6d3a1937f1c1701fe88dc1396d5fa788e2571b017dc3da6a093
+2035600 0021ab4e6cfa94e65ccbe834f0ede89f63c4864afda70b57c18f269fa77d3be8
+2036000 0007d559220b99f6e29e32895b9c565704ec61e6d7e14d2fdb662bfe6014b829
+2036400 001b706d5fd4da4c1b813f8c94941f4b7b5791d1f971758a75d9d7ac5a6e41b3
+2036800 003a3aa7d3aa02416cb1dba82b88b5166b46b2977f871f7b1c8bd8857bd3902f
+2037200 000faa7c1438ccf0bb2ddda6ff023312b7843228df27be2bfe236f346d7f4b87
+2037600 0040f0cc29f01e9e945507f60e7f8c532f22b10f5b4075448709592c30312174
+2038000 00251e2a9458e5282abaee9f2b361d4c2d06e9b7d56f1f66bdf4e960b322a323
+2038400 0027648723285e82e743d38f432b889e7668d3aa0e77ff8e6e8b8eb9ce2be550
+2038800 0045be9887bd216176bda10f8efb97212479ce99cf17db37f25f790cffd06669
+2039200 000546c4542020157da0f40516f82aebdc760539b21915ad6247b240e83027fc
+2039600 0010dd5c86acf59d5bf52697ebae06f8eb9603188235168be94c22309aa85001
+2040000 000eb52c4e328d62f1534aa382e8694e76a5a2390322f83e33e503b5dc7ae06f
+2040400 0006a9c1958467b0bbcf805228fcf29a3b3e5a20da96e91133f0fcbe63720c04
+2040800 0033c40dfc5144e8957b1162988a628384d7921ae6a00c1bae10ccc554b8feaf
+2041200 001a4ca772f815ca48f6fdf33a7a8a336f81a775e9870bcc897fd64ed45e1eb4
+2041600 002900d746f67012caef8fbf9df12dd8fb0db2ae1314ada0a6f2aed43811b26c
+2042000 00272f520bdf363a5827bf2f0012889b3687330ea6894afeb55d4509e3ed3607
+2042400 0026eaa3a98ef58b2b888111212d6a3e2a4e086990890de64d0c36b8752348cf
+2042800 00644c27b355e78fb4ebb1ecb46982d6a304f078bbc001758441c60525e29d95
+2043200 003a4286ee6e2b81df21f568748314109a9525fc5ddbdd79f4db8c27fc5e7efe
+2043600 002e357cb60df11b90b657cd5dee47025dfbe71d7e1db17286bd73fc7547024a
+2044000 008aa78c9a9f5c4800bfe96e664aa49788bbb52a57eecb22cbd5f194a8430f8a
+2044400 0028cf33dc54a3d3320c6eb8997a12cc81f199325243ffb46d1243ad52d36881
+2044800 002e00ebe1faddf6fa8918918acc9179b8757e9193a36ba75eda2ea83a77db1d
+2045200 001b530672e8eea9784ef3d56febfe77c0f91fcf69209ee90277684290710aeb
+2045600 006ab918afe279e862c909abe188718c4535a41fa9336488d8f98a0a9b7784e7
+2046000 0003310d3c4b2cfd512df1f791179a63cfcd98f14224a99fdeeec43cfb949fd1
+2046400 003a66bc9263bacd6b29421a5d063e4084d05158bc84b18b7d74eaaf1cb3c387
+2046800 004e39aa04132ddf44f9ffbd184c6dea0d8b4eafe9b21d936f1390bcd533083e
+2047200 0021fd7bc1ebf8eacc8fb1654baedcf886bacbb9303d2b8a25874d43e3633fed
+2047600 001d8ce8cd3df20b140cfdf24acac6aba4230c4da1ab0d2331f416c1edf64964
+2048000 00178fc5f25ca45272e0af89e5df2a7be9c87b7e8108c64693b9c6facdc199cc
+2048400 003f584ca1395c5df8c8088bf55cf681df26c5899599f8fd3f6f81e0384a4e97
+2048800 0022c3f3096e98e65d410db2f11aaf65a6162dfbc793cbb535878c43ac2feab4
+2049200 00314fb0010a845e070c1b994cc3015da12374e4c607d83de075defec3390c83
+2049600 0012f0590013a0f0db12aab95d741ffcdcbf839a487b8f0600d4a29466e6fbe6
+2050000 002655de7a40e37d3801ff41d427c4b1bb192e0b788dc8813fc961f0bf0afb8f
+2050400 002c4697969f27e375520e52a7443450e81bc7b792a9b84c08814eb5a2cb0991
+2050800 001687b95a298ba4ee0009e453f632943f521d86566e9e37af6ee1958f401552
+2051200 002a2ef18bdae38ae945507aa3aa7433113a87463e67a8b38a34337d67a59edf
+2051600 005084be0bc07a9bbe40622877b1a9b4fef9ce9d9acfb697af575ef6f4b1e6fc
+2052000 003c71deab944e87704905f1733deda5a76f745e9f97ef2cdd0f209feb99beaf
+2052400 0018d6fca006b35c05e3def63356a194f4f77ecd5af6b5bc3a230d2caf2003f3
+2052800 002825cb69adc0e8e75118e511c3a5ff9643a1f058123e32977b92c9cf352438
+2053200 00817bb125f3cdd6998a87cba0cd774ec01cf699019ef09789883240f9475eae
+2053600 001a0a98c27b408fd12fd1f2444303abc6ddb0ca0a18a882f350aa1106420aa9
+2054000 0017590fe16f3be8f00d5cf0b12ea6a375fb253d8c7ac5d5f7308c634c12c80b
+2054400 004434a30ee4ad95dda82837521f5f307dd2658a6cd4f2228b2601998694edb9
+2054800 0005bd116d0cb8fcc0c24bc823e1c3f991e0f78d0d50d4aaf72bac9b00652f94
+2055200 00128ce0626c48599f11bd08ade3a438cd9b9e5dbb15e2ec52d1928f61740a7d
+2055600 00093d79f8dad1ece8c6d57d6b7af56336a16afcbaae333c87b12a32daf4cb84
+2056000 005ce429a9b81ecb7707bd9f7dbb614589b4903c88e8b84715a4106a223fb9fa
+2056400 001a5bba505ffebb1979c7a39aa98cb345fb367cd82e51d2bd66aa7e886d32d3
+2056800 003167eb817eaf67b80ccf32634e21f6bbf3a6464fa488d5db0aef4fb9b382a3
+2057200 001ef54d3b3b876881929e8e4bf05e6b4824d7cf8588e69b90200ed74340db2c
+2057600 001db360e3a95fcf4719bda2fbdfec0ded8dcba815cfe2df7f4383a96c8be07d
+2058000 0034bcc1e62b352b19f9b81e3365cde809973d0ee951d515787c44583e33f860
+2058400 0000611bd2bf67d6640a56e613ad62faa2939cc5fef9b5b52b7d1e52c32188d8
+2058800 000b40054df8618bad75f2f164a88f214b183f3864f16572a8c5d46f76d09f61
+2059200 0027d9c116c4c1fe881ac57e97608ace8645aab85c855d4308f89271687f63a9
+2059600 002d2141fe726fbcd17d5e178bc262012a7bd9846c9380e630cb1f93a82e4478
+2060000 0009b6f13f41de7235e23e809daf586b56996b3f948a7de1a1f234e2cddc00f6
+2060400 005e1b69fc0ea32b22adbc418d80afc28a20b34a91ab6e751e81e69cf09da06e
+2060800 000f47d1eb8ee2146bb1b3a30ddcb49cd183edbc3527369c2169a7f6e82ac2e3
+2061200 003e50a781734613700b7938eedcb3e5b2319669a4eedc80374f66b895e4adf2
+2061600 01320e00199b50eaffee1a1f1011bda432f9e432c2e4554ca112f87e499d3aa6
+2062000 00017aa7515c3a421b5abe7285a75acc819f6304ade62905207b87a10fe82094
+2062400 000d65d68f7b11b975ccf4699534f69f6c729fd8903381a4dd904b82bbaef367
+2062800 077f08ad36527df22617dac9cc3cae1bbc36d2113da03dcfb9db3669dde6ed4f
+2063200 00c533a76682a672f3ff9391004ee05d404ba26d67723ffc0d055e016d4c1bd1
+2063600 00846c18f6d3434ffec7dea8ebc03021f2b693f761a2b6c034b8c6b7c4dc0bd6
+2064000 0095a37e4eec0d4c4db17a794eb391fa97e78941c7465cf0d910ba4af0f71445
+2064400 00418f3451053cf48088a5aa2495fc46023428ee4c323f884ce82fbfc62c892b
+2064800 000f995c27ef8c18f93cc607ee293ec348064490facf67ba3c36316fe13cb117
+2065200 0034e6f080f2f856e3e3335dff1fdb53924dbca0a7fe473d0e16959fe117e044
+2065600 00650dfe83222105594c89bfba89072c9bc5a1835436ae8adcd7a87ba939baa9
+2066000 0063c6aa0e81d7f6301aa273ef144611cd7064fe67b77483576f85e36f2808f7
+2066400 01909fc220b9531f080dc6d2b6b199694fade497794eddb7b54f8c252edba7c6
+2066800 00f1bbceab9dc2b8e58cf6f71dda9e93229f14f2f12c15f6e473d1498190cfc0
+2067200 0194c44fa83afb8e827205f2fc24a9be1aa96ec130b64a2330d86fdaae2fb9bc
+2067600 00f198f416521f8c33532b1e332354fbded8aead94483c5a915b704bf5655c6d
+2068000 007d58c30f8a048420225d0f761f8ab20992b939ed3ae9e6dca28b5e6260f9f1

zebra-state/Cargo.toml

@@ -15,6 +15,7 @@ dirs = "4.0.0"
 displaydoc = "0.2.3"
 futures = "0.3.24"
 hex = "0.4.3"
+indexmap = "1.9.1"
 itertools = "0.10.5"
 lazy_static = "1.4.0"
 metrics = "0.20.1"

zebra-state/src/error.rs

@@ -51,6 +51,10 @@ pub struct CommitBlockError(#[from] ValidateContextError);
 #[non_exhaustive]
 #[allow(missing_docs)]
 pub enum ValidateContextError {
+    #[error("block parent not found in any chain")]
+    #[non_exhaustive]
+    NotReadyToBeCommitted,
+
     #[error("block height {candidate_height:?} is lower than the current finalized height {finalized_tip_height:?}")]
     #[non_exhaustive]
     OrphanedBlock {