Code

Non finalized block commit channel#5210

Code

Closed

arya2 wants to merge 32 commits intoblock-commit-channelZcashFoundation/zebra:block-commit-channelfrom non-finalized-block-commit-channelZcashFoundation/zebra:non-finalized-block-commit-channelCopy head branch name to clipboard

+1,268-608

Commits

Commits on Sep 16, 2022

• Move the finalized block queue into the StateService

  teor2345

  committed
  aa3cae4

• Move the queued_blocks module to the state service

  teor2345

  committed
  f2809c5

• Move QueuedFinalized into queued_blocks

  teor2345

  committed
  b2a2526

• Move the queued_blocks tests into their own module

  teor2345

  committed
  cb2c0c4

• Make the FinalizedState cloneable

  teor2345

  committed
  8aeebda

• Add a new block commit task and channels, that don't do anything yet

  teor2345

  committed
  79c8173

• Add last_block_hash_sent to the state service, to avoid database accesses

  teor2345

  committed
  340d394

• Update last_block_hash_sent regardless of commit errors

  teor2345

  committed
  fb7947c

• Rename a field to StateService.max_queued_finalized_height

  teor2345

  committed
  e0584a3

• Commit finalized blocks to the state in a separate task

  teor2345

  committed
  ca8ddf0

• Check for panics in the block write task

  teor2345

  committed
  ced7ffb

• Wait for the block commit task in tests, and check for errors

  teor2345

  committed
  d885e3c

• Always run a proptest that sleeps once

  teor2345

  committed
  f94cbc6

• Add extra debugging to state shutdowns

  teor2345

  committed
  dcedc8b

• Work around a RocksDB shutdown bug

  teor2345

  committed
  c0c106d

• Close the finalized block channel when we're finished with it

  teor2345

  committed
  8863835

• Only reset state queue once per error

  teor2345

  committed
  1dce756

• Update some TODOs

  teor2345

  committed
  9fd7b85

• Add a module doc comment

  teor2345

  committed
  ec63d4c

• Drop channels and check for closed channels in the block commit task

  teor2345

  committed
  3571ac1

• Close state channels and tasks on drop

  teor2345

  committed
  af15b5d

• Remove some duplicate fields across StateService and ReadStateService

  teor2345

  committed
  4d11b7a

• Try tweaking the shutdown steps

  teor2345

  committed
  23094b8

• Update and clarify some comments

  teor2345

  committed
  633e33e

• Clarify another comment

  teor2345

  committed
  7d9fcfa

• Don't try to cancel RocksDB background work on drop

  teor2345

  committed
  21f902b

• Fix up some comments

  teor2345

  committed
  fbb6fae

• Remove some duplicate code

  teor2345

  committed
  dd8ed5b

• Remove redundant workarounds for shutdown issues

  teor2345

  committed
  09349cb

Commits on Sep 19, 2022

• moves commit ops in queue_and_commit_non_finalized method of StateService to block commit task

  arya2

  committed
  285baea

• sends individual non-finalized blocks over the channel and responds to queued blocks with an error if the channel.send fails

  arya2

  committed
  27fb54d

Commits on Sep 20, 2022

• use exclusive ref to chain_tip_sender in update_latest_chain_channels instead of mutex

  arya2

  committed
  1059ff6