Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Split a long full sync job #5001

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix(ci): Split a long full sync job #5001

merged 1 commit into from
Aug 30, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

A full sync job is timing out, so we want to split the job.

Designs

I followed the instructions in:
https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/continuous-integration.md#resolving-ci-sync-timeouts

Solution

  • Add a job that stops at height 1780k, roughly 4 hours long

Review

Anyone can review this PR, we need it to fix full syncs on main.

Reviewer Checklist

  • CI passes

Follow Up Work

We might want to find an alternative to all these extra jobs, maybe #4937 will speed up these syncs.

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures labels Aug 30, 2022
@teor2345 teor2345 requested a review from a team as a code owner August 30, 2022 07:41
@teor2345 teor2345 self-assigned this Aug 30, 2022
@teor2345 teor2345 requested review from gustavovalverde and removed request for a team August 30, 2022 07:41
gustavovalverde
gustavovalverde approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's time to think on a self hosted runner, at least. So we don't have to keep creating more jobs, and just allow a hosted to run until it's done.

mergify bot added a commit that referenced this pull request Aug 30, 2022
@mergify
Merge of #5001
cf8a80f
@mergify mergify bot mentioned this pull request Aug 30, 2022
Closed
@mergify mergify bot merged commit e9597c0 into main Aug 30, 2022
@mergify mergify bot deleted the fix-full-sync-timeout branch August 30, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavovalverde gustavovalverde gustavovalverde approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @gustavovalverde