ci(deploy): do not run versioning job when pushing to main
#4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior: When a push was detected in the `main` branch, the workflow would run the `versioning` job and crash trying to detect the version being deployed as there was none. Expected behavior: Do not fail the `versioning` job when pushing to `main` Solution: Limit the `versioning` job to only run when a release event is triggered and allow the `deploy-nodes` job to run even if `versioning` is skipped
gustavovalverde
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior:
When a push was detected in the
mainbranch, the workflow would run theversioningjob and crash trying to detect the version being deployed asthere was none.
Expected behavior:
Do not fail the
versioningjob when pushing tomainSolution:
Limit the
versioningjob to only run when a release event is triggeredand allow the
deploy-nodesjob to run even ifversioningis skippedReview
This is an urgent PR to anyone from the @ZcashFoundation/devops-reviewers to review